Gigedit caveats

You name it!
User avatar
dahnielson
Moderator
Posts: 632
Joined: Wed Jan 23, 2008 11:25 pm
Location: Linköping / Tranås, Sweden
Contact:

Re: Gigedit caveats

Post by dahnielson » Sun Feb 10, 2008 2:10 pm

Andreas wrote:I could replicate the bug without using "save as". I think there is a bug in the RIFF::Save() function, I'm investigating that at the moment.
In essence: "It's not you, it's me."
Anders Dahnielson

Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux

User avatar
cuse
Developer
Posts: 366
Joined: Wed Jan 23, 2008 10:07 pm
Location: Germany

Re: Gigedit caveats

Post by cuse » Sun Feb 10, 2008 2:19 pm

dahnielson wrote: But, there should be some kind of prevention against this so this situation won't happen. Don't think I will be the last person to do that mistake...
No doubt about that!

Andreas
Developer
Posts: 214
Joined: Sun Feb 03, 2008 8:33 am

Re: Gigedit caveats

Post by Andreas » Sun Feb 10, 2008 5:09 pm

I've committed a fix in libgig now. (Not for "save as" to same file, but for "save" to same file after adding samples). Please test.

User avatar
cuse
Developer
Posts: 366
Joined: Wed Jan 23, 2008 10:07 pm
Location: Germany

Re: Gigedit caveats

Post by cuse » Tue Feb 12, 2008 3:18 pm

I just commited something against that "Save As..." trap. There's still no check whether the selected file is the same one, but the initial filename set in the "Save As..." dialog is now "copy_of_<filename>" and at the bottom of the dialog there is a warning, that using "Save As..." to the same file will corrupt the sample wave data.

I hope that's sufficient for now.

User avatar
dahnielson
Moderator
Posts: 632
Joined: Wed Jan 23, 2008 11:25 pm
Location: Linköping / Tranås, Sweden
Contact:

Re: Gigedit caveats

Post by dahnielson » Tue Feb 12, 2008 3:34 pm

cuse wrote:I just commited something against that "Save As..." trap. There's still no check whether the selected file is the same one, but the initial filename set in the "Save As..." dialog is now "copy_of_<filename>" and at the bottom of the dialog there is a warning, that using "Save As..." to the same file will corrupt the sample wave data.

I hope that's sufficient for now.
Agree. It's not fool proof. But at least it makes you think twice and indicate that you just might be a fool to not obey the instructions.
Anders Dahnielson

Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux

User avatar
dahnielson
Moderator
Posts: 632
Joined: Wed Jan 23, 2008 11:25 pm
Location: Linköping / Tranås, Sweden
Contact:

Re: Gigedit caveats

Post by dahnielson » Thu Feb 14, 2008 10:01 pm

A question.

When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.
Anders Dahnielson

Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux

Andreas
Developer
Posts: 214
Joined: Sun Feb 03, 2008 8:33 am

Re: Gigedit caveats

Post by Andreas » Sun Feb 17, 2008 2:19 pm

dahnielson wrote:When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.
Actually, that is a feature, or at least something that I spent some time to implement. The thing is, a sample may contain information about unity note, fine tune and loops. When you drag-and-drop a sample I wanted to make use of that information, so it is copied from the sample to the dimension region.

User avatar
cuse
Developer
Posts: 366
Joined: Wed Jan 23, 2008 10:07 pm
Location: Germany

Re: Gigedit caveats

Post by cuse » Sun Feb 17, 2008 4:41 pm

How about (another) checkbox for en/disabling applying the dragged sample's meta informations?

Post Reply