In essence: "It's not you, it's me."Andreas wrote:I could replicate the bug without using "save as". I think there is a bug in the RIFF::Save() function, I'm investigating that at the moment.
Gigedit caveats
- dahnielson
- Moderator
- Posts: 632
- Joined: Wed Jan 23, 2008 11:25 pm
- Location: Linköping / Tranås, Sweden
- Contact:
Re: Gigedit caveats
Anders Dahnielson
Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux
Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux
Re: Gigedit caveats
No doubt about that!dahnielson wrote: But, there should be some kind of prevention against this so this situation won't happen. Don't think I will be the last person to do that mistake...
Re: Gigedit caveats
I've committed a fix in libgig now. (Not for "save as" to same file, but for "save" to same file after adding samples). Please test.
Re: Gigedit caveats
I just commited something against that "Save As..." trap. There's still no check whether the selected file is the same one, but the initial filename set in the "Save As..." dialog is now "copy_of_<filename>" and at the bottom of the dialog there is a warning, that using "Save As..." to the same file will corrupt the sample wave data.
I hope that's sufficient for now.
I hope that's sufficient for now.
- dahnielson
- Moderator
- Posts: 632
- Joined: Wed Jan 23, 2008 11:25 pm
- Location: Linköping / Tranås, Sweden
- Contact:
Re: Gigedit caveats
Agree. It's not fool proof. But at least it makes you think twice and indicate that you just might be a fool to not obey the instructions.cuse wrote:I just commited something against that "Save As..." trap. There's still no check whether the selected file is the same one, but the initial filename set in the "Save As..." dialog is now "copy_of_<filename>" and at the bottom of the dialog there is a warning, that using "Save As..." to the same file will corrupt the sample wave data.
I hope that's sufficient for now.
Anders Dahnielson
Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux
Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux
- dahnielson
- Moderator
- Posts: 632
- Joined: Wed Jan 23, 2008 11:25 pm
- Location: Linköping / Tranås, Sweden
- Contact:
Re: Gigedit caveats
A question.
When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.
When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.
Anders Dahnielson
Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux
Ardour2, Qtractor, Linuxsampler, M-AUDIO Delta 1010, Axiom 61, Korg D12, AKAI S2000, E-MU Proteus 2k, Roland R-5, Roland HP 1300e, Zoom RFX-1000, 4GB RAM x86_64 Intel Pentium Dual 1.80GHz Gentoo Linux
Re: Gigedit caveats
Actually, that is a feature, or at least something that I spent some time to implement. The thing is, a sample may contain information about unity note, fine tune and loops. When you drag-and-drop a sample I wanted to make use of that information, so it is copied from the sample to the dimension region.dahnielson wrote:When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.
Re: Gigedit caveats
How about (another) checkbox for en/disabling applying the dragged sample's meta informations?