bb.linuxsampler.org

Andreas wrote:I could replicate the bug without using "save as". I think there is a bug in the RIFF::Save() function, I'm investigating that at the moment.

In essence: "It's not you, it's me."

dahnielson wrote: But, there should be some kind of prevention against this so this situation won't happen. Don't think I will be the last person to do that mistake...

No doubt about that!

I've committed a fix in libgig now. (Not for "save as" to same file, but for "save" to same file after adding samples). Please test.

I just commited something against that "Save As..." trap. There's still no check whether the selected file is the same one, but the initial filename set in the "Save As..." dialog is now "copy_of_<filename>" and at the bottom of the dialog there is a warning, that using "Save As..." to the same file will corrupt the sample wave data.

I hope that's sufficient for now.

cuse wrote:I just commited something against that "Save As..." trap. There's still no check whether the selected file is the same one, but the initial filename set in the "Save As..." dialog is now "copy_of_<filename>" and at the bottom of the dialog there is a warning, that using "Save As..." to the same file will corrupt the sample wave data.

I hope that's sufficient for now.

Agree. It's not fool proof. But at least it makes you think twice and indicate that you just might be a fool to not obey the instructions.

A question.

When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.

dahnielson wrote:When you drag and drop a sample the settings, like unity note, are all reset to the default. Is that a bug or a feature? The fact is that I experience it as an annoyance, especially when I'm doing manual sample replacement.

Actually, that is a feature, or at least something that I spent some time to implement. The thing is, a sample may contain information about unity note, fine tune and loops. When you drag-and-drop a sample I wanted to make use of that information, so it is copied from the sample to the dimension region.

How about (another) checkbox for en/disabling applying the dragged sample's meta informations?